Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the suppressors #4451

Merged
merged 5 commits into from Jan 5, 2022
Merged

Add documentation for the suppressors #4451

merged 5 commits into from Jan 5, 2022

Conversation

BraisGabin
Copy link
Member

closes #4440

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #4451 (a1a8e0e) into main (21a751a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4451      +/-   ##
============================================
- Coverage     84.34%   84.32%   -0.02%     
+ Complexity     3299     3298       -1     
============================================
  Files           473      473              
  Lines         10532    10591      +59     
  Branches       1885     1907      +22     
============================================
+ Hits           8883     8931      +48     
- Misses          671      675       +4     
- Partials        978      985       +7     
Impacted Files Coverage Δ
...ch/detekt/core/suppressors/AnnotationSuppressor.kt 80.76% <ø> (ø)
...osch/detekt/core/suppressors/FunctionSuppressor.kt 100.00% <ø> (ø)
...osch/detekt/core/baseline/BaselineResultMapping.kt 78.57% <0.00%> (-2.68%) ⬇️
...lab/arturbosch/detekt/rules/style/VarCouldBeVal.kt 87.50% <0.00%> (-2.09%) ⬇️
...io/gitlab/arturbosch/detekt/core/BindingContext.kt 41.17% <0.00%> (+5.17%) ⬆️
.../arturbosch/detekt/core/baseline/BaselineFacade.kt 85.71% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a751a...a1a8e0e. Read the comment docs.

docs/pages/suppressors.md Outdated Show resolved Hide resolved
BraisGabin and others added 2 commits January 5, 2022 09:25
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 🎉

docs/pages/suppressors.md Outdated Show resolved Hide resolved
docs/pages/suppressors.md Outdated Show resolved Hide resolved
---

The `Suppressor`s are a tool that you can use to customize the reports of detekt. They allow you to (surprise) suppress
some issues detected by some rules, and they can be applied to any rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this on a single line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can I ask why do you prefer them in one line instead of wrapping the lines? I do like them more in a single line but I added them like this to be "safe"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads better on every Markdown processors. Generally, MD processors wrap long lines so it's easier to find paragraph breaks, regardless of the width of the reader's screen.

If you add newlines in the middle of the paragraph, then the line wrapping will still happen + the newlines will be rendered as well. So sometimes you end up with 2 words on a line for no apparent reason, and so on.

docs/pages/suppressors.md Outdated Show resolved Hide resolved
docs/pages/suppressors.md Outdated Show resolved Hide resolved
docs/pages/suppressors.md Outdated Show resolved Hide resolved
BraisGabin and others added 2 commits January 5, 2022 22:18
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
@BraisGabin BraisGabin merged commit 781395c into main Jan 5, 2022
@BraisGabin BraisGabin deleted the fix-4440 branch January 5, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for Suppressors
5 participants