Function generics matcher #4460
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4460 +/- ##
=========================================
Coverage 84.55% 84.56%
Complexity 3397 3397
=========================================
Files 484 484
Lines 11272 11276 +4
Branches 2059 2060 +1
=========================================
+ Hits 9531 9535 +4
Misses 698 698
Partials 1043 1043
Continue to review full report at Codecov.
|
BraisGabin
force-pushed
the
function-extension-matcher
branch
from
f73771a
to
5d8588f
Compare
BraisGabin
force-pushed
the
function-generics-matcher
branch
from
eefa7bc
to
746dcaa
Compare
BraisGabin
force-pushed
the
function-extension-matcher
branch
from
5d8588f
to
dc617af
Compare
BraisGabin
force-pushed
the
function-generics-matcher
branch
from
746dcaa
to
aa6655a
Compare
| @@ -33,11 +35,12 @@ sealed class FunctionMatcher { | |||
| private val parameters: List<String> | |||
| ) : FunctionMatcher() { | |||
| override fun match(callableDescriptor: CallableDescriptor): Boolean { | |||
| if (callableDescriptor.fqNameOrNull()?.asString() != fullyQualifiedName) return false | |||
| val descriptor = callableDescriptor.original | |||
There was a problem hiding this comment.
Q: What is .original doing here? Why is it needed?
There was a problem hiding this comment.
That get's the function definition instead of the function call. If I request the type of the parameter of list("hello") it will say String but if I ask for the type of the original I get T.
There was a problem hiding this comment.
Gotcha 👍 Thanks for clarifying
BraisGabin
force-pushed
the
function-extension-matcher
branch
from
dc617af
to
6a9f0ca
Compare
BraisGabin
force-pushed
the
function-generics-matcher
branch
from
aa6655a
to
5c370c3
Compare
|
I would like to merge this one in 1.20 too if possible. This PR was waiting for #4459 to be merged because it depends on that code. |
BraisGabin
force-pushed
the
function-generics-matcher
branch
from
5c370c3
to
568c2a4
Compare
|
I'm fine adding this, but we need some follow-up docs for this to the website |
|
🤔 I don't think we need to add new documentation here. The current documentation matchs what this matcher does. This one is more a "bug-fix" than a new feature. I mean, for sure it is a new feature but for a user it could seems like the same. The PR that introduced real changes was #4459 and I added the documentation directly in it. https://github.com/detekt/detekt/pull/4459/files#diff-76703cf8efe31f0c7e06926568e0d1e248eb82cb63bd40b0b37698dc35bed70fR52 |
* Match functions with generics * Add test to ensure that #4448 is fixed
Match generic names in signature functions.
Now ForbiddenMethod call allows to forbid
kotlin.runCatching {}but allowingrunCatching {}.closes #4448