Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VarCouldBeVal] Override vars will not be flagged if bindingContext is not set #4477

Merged
merged 3 commits into from Jan 28, 2022
Merged

[VarCouldBeVal] Override vars will not be flagged if bindingContext is not set #4477

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d45b616
Override vars will not be flagged if bindingContext is not set
severn-everett Jan 10, 2022
776f5c9
Renamed test to correspond to test provided in issue
severn-everett Jan 10, 2022
c366477
Addressing PR comment
severn-everett Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/VarCouldBeVal.kt
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ import io.gitlab.arturbosch.detekt.api.Rule
import io.gitlab.arturbosch.detekt.api.Severity
import io.gitlab.arturbosch.detekt.api.internal.ActiveByDefault
import io.gitlab.arturbosch.detekt.api.internal.RequiresTypeResolution
import io.gitlab.arturbosch.detekt.rules.isOverride
import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.psi.KtBinaryExpression
Expand Down Expand Up @@ -193,6 +194,7 @@ class VarCouldBeVal(config: Config = Config.empty) : Rule(config) {
return when {
!isVar -> false
isLocal || isPrivate() -> true
isOverride() && bindingContext == BindingContext.EMPTY -> false
else -> {
// Check for whether property belongs to an anonymous object
// defined in a function.
Expand Down
16 changes: 16 additions & 0 deletions ...-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/VarCouldBeValSpec.kt
View file
Open in desktop
@@ -1,6 +1,7 @@
package io.gitlab.arturbosch.detekt.rules.style

import io.gitlab.arturbosch.detekt.rules.setupKotlinEnvironment
import io.gitlab.arturbosch.detekt.test.compileAndLint
import io.gitlab.arturbosch.detekt.test.compileAndLintWithContext
import org.assertj.core.api.Assertions.assertThat
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
Expand Down Expand Up @@ -410,6 +411,21 @@ class VarCouldBeValSpec : Spek({
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}

it("does not report when an object initializes a variable directly - without type solving") {
val code = """
interface I {
var optionEnabled: Boolean
}
fun test(): I {
val o = object: I {
override var optionEnabled: Boolean = false
}
return o
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
}
}
})