Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overridden function reporting for CanBeNonNullable rule #4497

Merged
merged 1 commit into from Jan 19, 2022
Merged

Fix overridden function reporting for CanBeNonNullable rule #4497

merged 1 commit into from Jan 19, 2022

Conversation

keymusicman
Copy link
Contributor

Fix #4486. Now CanBeNonNullable does not report overridden functions parameters

@BraisGabin BraisGabin added this to the 1.20.0 milestone Jan 19, 2022
@BraisGabin BraisGabin merged commit bf698f0 into detekt:main Jan 19, 2022
@keymusicman keymusicman deleted the canbenonnullable-fix-override branch January 24, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@marschwar marschwar marschwar approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Rule CanBeNonNullable should not report when function is overridden
4 participants
@keymusicman @BraisGabin @marschwar @cortinico