Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MaxLineLength] Fix signature in for blank characters in the Baseline #4504

Merged
merged 1 commit into from Jan 30, 2022
Merged

[MaxLineLength] Fix signature in for blank characters in the Baseline #4504

merged 1 commit into from Jan 30, 2022

Conversation

marschwar
Copy link
Contributor

This fixes #4480

@BraisGabin BraisGabin added this to the 1.20.0 milestone Jan 27, 2022
@richdapice richdapice mentioned this pull request Jan 27, 2022
Closed
@BraisGabin
Copy link
Member

If we end up reverting #4335 would we want to merge this anyway? Because if we don't want this if we revert #4335 probably what we should do is just revert #4335.

@cortinico cortinico changed the title Fix signature in MaxLineLength rule [MaxLineLength] Fix signature in for blank characters in the Baseline Jan 28, 2022
@marschwar
Copy link
Contributor Author

I vote to merge this regardless as it allows to differentiate between two similar violations in the same file

@cortinico cortinico merged commit a6a2614 into detekt:main Jan 30, 2022
@marschwar marschwar deleted the maxlinelength-signature branch January 30, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Baseline not catching multiline string literals correctly
3 participants
@marschwar @BraisGabin @cortinico