Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable UnnecessaryInnerClass for tests #4510

Closed
wants to merge 1 commit into from

Conversation

marschwar
Copy link
Contributor

In junit inner classes are a way to structure test contexts.

In junit inner classes are a way to structure test contexts.
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #4510 (48558c0) into main (8a69676) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4510   +/-   ##
=========================================
  Coverage     84.14%   84.14%           
  Complexity     3315     3315           
=========================================
  Files           476      476           
  Lines         10882    10882           
  Branches       2015     2015           
=========================================
  Hits           9157     9157           
  Misses          692      692           
  Partials       1033     1033           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a69676...48558c0. Read the comment docs.

@chao2zhang
Copy link
Member

What do you think about #4509?

@marschwar
Copy link
Contributor Author

#4509 could be a real fix

@marschwar marschwar closed this Jan 23, 2022
@marschwar marschwar deleted the disable-inner-class-check branch January 23, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants