New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests in detekt-rules-errorprone to junit #4523
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4523 +/- ##
=========================================
Coverage 84.42% 84.42%
Complexity 3323 3323
=========================================
Files 479 479
Lines 11139 11139
Branches 2039 2039
=========================================
Hits 9404 9404
Misses 700 700
Partials 1035 1035 Continue to review full report at Codecov.
|
I'm having this same issue in #4459 (https://github.com/detekt/detekt/runs/4934052976?check_suite_focus=true#step:4:556) It seems that our compile-test-snippets is a bit flaky. If I change the number of engines here: detekt/detekt-test-utils/src/main/kotlin/io/github/detekt/test/utils/KotlinScriptEnginePool.kt Line 13 in 4a89a25
From 8 to 1 a lot of issues appear on And, in my case if I change the number from 8 to 9 all works perfectly fine... That PR is older than our PRs related with JUnit so JUnit is not the reason. |
Really strange... |
Any idea why we have 8 of those? It doesn't seem that we are doing any parallel job here so with one it should be enough. |
No idea. It may also be something different entirely. It could well be, that I have some errors in the scripts to compile. I will investigate. |
In this case it seems like there is something wrong with the snippets in |
There is a merge conflict on this PR now. @marschwar are you able to take a look. |
Part of #4450