Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MaxLineLength violation on detekt main inside IgnoredReturnValue rule #4539

Merged
merged 1 commit into from Jan 28, 2022
Merged

Fix MaxLineLength violation on detekt main inside IgnoredReturnValue rule #4539

merged 1 commit into from Jan 28, 2022

Conversation

marschwar
Copy link
Contributor

Fixes the detekt task on main

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #4539 (5e8f827) into main (90ae9ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4539   +/-   ##
=========================================
  Coverage     84.11%   84.11%           
  Complexity     3312     3312           
=========================================
  Files           477      477           
  Lines         10920    10920           
  Branches       2029     2029           
=========================================
  Hits           9185     9185           
  Misses          700      700           
  Partials       1035     1035
Impacted Files Coverage Δ
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 82.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ae9ec...5e8f827. Read the comment docs.

@marschwar marschwar merged commit 5176e41 into detekt:main Jan 28, 2022
@marschwar marschwar deleted the fix-main branch January 28, 2022 23:38
@cortinico cortinico changed the title Fix MaxLineLength violation in IgnoredReturnValue rule Fix MaxLineLength violation on detekt main inside IgnoredReturnValue rule Jan 30, 2022
@cortinico cortinico added this to the 1.20.0 milestone Jan 30, 2022
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marschwar @BraisGabin @cortinico