Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse setReportOutputConventions #4546

Merged
merged 3 commits into from Feb 4, 2022
Merged

Reuse setReportOutputConventions #4546

merged 3 commits into from Feb 4, 2022

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jan 30, 2022

Reuse the same logic.

@codecov
Copy link

codecov bot commented Jan 30, 2022 •
edited

Codecov Report

Merging #4546 (20e7595) into main (10e9e4c) will not change coverage.
The diff coverage is n/a.

❗ Current head 20e7595 differs from pull request most recent head c9f3cd5. Consider uploading reports for the commit c9f3cd5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4546   +/-   ##
=========================================
  Coverage     84.13%   84.13%           
  Complexity     3313     3313           
=========================================
  Files           477      477           
  Lines         10922    10922           
  Branches       2030     2030           
=========================================
  Hits           9189     9189           
  Misses          700      700           
  Partials       1033     1033

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e9e4c...c9f3cd5. Read the comment docs.

@Goooler Goooler changed the title Reuse outputLocation.convention Reuse setReportOutputConventions Feb 1, 2022
@cortinico cortinico added this to the 1.20.0 milestone Feb 1, 2022
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Feb 1, 2022
@3flex 3flex merged commit f626273 into detekt:main Feb 4, 2022
@Goooler Goooler deleted the reuse branch February 4, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Goooler @cortinico @3flex