Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "trim values when parsing the baseline (#4335)" #4548

Merged
merged 1 commit into from Jan 31, 2022
Merged

Conversation

BraisGabin
Copy link
Member

This reverts #4335 (26fd459)

Fixes #4537

@BraisGabin BraisGabin added this to the 1.20.0 milestone Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #4548 (bcff930) into main (a6a2614) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4548      +/-   ##
============================================
+ Coverage     84.10%   84.13%   +0.02%     
  Complexity     3313     3313              
============================================
  Files           477      477              
  Lines         10925    10922       -3     
  Branches       2030     2030              
============================================
  Hits           9189     9189              
  Misses          700      700              
+ Partials       1036     1033       -3     
Impacted Files Coverage Δ
...arturbosch/detekt/core/baseline/BaselineHandler.kt 95.00% <50.00%> (ø)
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.50% <0.00%> (-0.05%) ⬇️
...otlin/io/gitlab/arturbosch/detekt/core/TaskPool.kt 100.00% <0.00%> (ø)
...in/kotlin/io/github/detekt/report/xml/XmlEscape.kt 65.97% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a2614...bcff930. Read the comment docs.

@cortinico cortinico merged commit 1fbe3b8 into main Jan 31, 2022
@cortinico cortinico deleted the fix-baseline branch January 31, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing check for SpacingBetweenPackageAndImports issues contained in baseline 1.19.0
3 participants