Fix performance issue for regexp in Reporting.kt #4550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regexp object is compiled into an internal data structure during initialization. This could to a potential performance impact, if the `Regex()` constructor is called multiple times for the same pattern. Since the private function `truncatedMessage()` could be called a lot, this PR fixes this potential performance issue. Because of the overhead of object instantiation and regular expression compilation, reusing the initialized object is the recommended way.
Codecov Report
@@ Coverage Diff @@
## main #4550 +/- ##
=========================================
Coverage 84.42% 84.42%
Complexity 3323 3323
=========================================
Files 479 479
Lines 11139 11140 +1
Branches 2039 2039
=========================================
+ Hits 9404 9405 +1
Misses 700 700
Partials 1035 1035
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regexp object is compiled into an internal data structure during initialization.
This could to a potential performance impact, if the
Regex()constructor is called multiple times for the same pattern.Since the private function
truncatedMessage()could be called a lot, this PR fixes this potential performance issue.Because of the overhead of object instantiation and regular expression compilation, reusing the initialized object is the recommended way.