Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing /kotlin folder when running on Android projects #4554

Merged
merged 2 commits into from Feb 5, 2022

Conversation

cortinico
Copy link
Member

Fixes #4553

We were not including the .kotlinDirectories when setting the source for Detekt Android tasks. This PR fixes it.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #4554 (8757be5) into main (c854a2e) will increase coverage by 84.45%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4554       +/-   ##
===========================================
+ Coverage        0   84.45%   +84.45%     
- Complexity      0     3327     +3327     
===========================================
  Files           0      479      +479     
  Lines           0    11140    +11140     
  Branches        0     2039     +2039     
===========================================
+ Hits            0     9408     +9408     
- Misses          0      699      +699     
- Partials        0     1033     +1033     
Impacted Files Coverage Δ
...ch/detekt/rules/empty/EmptySecondaryConstructor.kt 66.66% <0.00%> (ø)
.../arturbosch/detekt/formatting/EditorConfigMerge.kt 100.00% <0.00%> (ø)
.../detekt/core/reporting/console/ComplexityReport.kt 100.00% <0.00%> (ø)
...t/metrics/processors/ProjectComplexityProcessor.kt 100.00% <0.00%> (ø)
...ab/arturbosch/detekt/core/config/Configurations.kt 84.37% <0.00%> (ø)
...t/rules/bugs/MapGetWithNotNullAssertionOperator.kt 81.25% <0.00%> (ø)
...detekt/rules/style/RedundantHigherOrderMapUsage.kt 74.46% <0.00%> (ø)
.../formatting/wrappers/SpacingAroundAngleBrackets.kt 100.00% <0.00%> (ø)
...io/github/detekt/tooling/dsl/ProjectSpecBuilder.kt 100.00% <0.00%> (ø)
...h/detekt/core/baseline/IndentingXMLStreamWriter.kt 56.33% <0.00%> (ø)
... and 469 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c854a2e...8757be5. Read the comment docs.

@BraisGabin
Copy link
Member

It seems that Windows isn't happy with those asserts >_<

@cortinico
Copy link
Member Author

Yeah I need to update the paths :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kotlin source directories not analysed when android variant is used
3 participants