Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Groovy DSL testing in DetektTaskDslSpec #4563

Merged
merged 2 commits into from Feb 7, 2022

Conversation

3flex
Copy link
Member

@3flex 3flex commented Feb 6, 2022

See #4560

Because I'm partway through migrating detekt-gradle-plugin tests to JUnit, it's easier for me to update this file first, then finish the JUnit migration for this project, then drop Groovy DSL tests in the remaining files.

First commit is the functional change without modifying whitespace, the second is just a reformat of the file to make it easier to review.

@3flex 3flex added the housekeeping Marker for housekeeping tasks and refactorings label Feb 6, 2022
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting to unblock. However please take a look at my comment on #4560 as I believe we should at least reintroduce a couple of Groovy tests (in a separate file maybe?).

@cortinico cortinico added this to the 1.20.0 milestone Feb 7, 2022
@3flex 3flex merged commit 56baa43 into detekt:main Feb 7, 2022
@3flex 3flex deleted the DGP/tests/drop-groovy branch February 7, 2022 10:28
Goooler pushed a commit to Goooler/detekt that referenced this pull request Feb 10, 2022
* Drop Groovy DSL testing in DetektTaskDslSpec

* Reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants