Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Gradle's configuration cache by default #4576

Merged
merged 2 commits into from Feb 9, 2022

Conversation

3flex
Copy link
Member

@3flex 3flex commented Feb 8, 2022

Gradle 7.4 introduces a feature to declare that individual tasks are incompatible with the configuration cache, allowing the feature to be enabled by default while skipping caching when there are tasks in the task graph that don't support it.

More information available in "Disable configuration caching when incompatible tasks are executed" section of the release notes: https://docs.gradle.org/7.4/release-notes.html#config-cache

This PR enables the configuration cache while declaring tasks known to be incompatible with it. Note that there may be some additional tasks that are discovered to be incompatible in future, so this config might need tweaking.

@cortinico cortinico added this to the 1.20.0 milestone Feb 8, 2022
@3flex 3flex added housekeeping Marker for housekeeping tasks and refactorings and removed gradle-plugin labels Feb 8, 2022
@3flex
Copy link
Member Author

3flex commented Feb 8, 2022

I've updated the label to "housekeeping" since I thought the yellow labels, including "gradle", related to the named subprojects? This doesn't change behaviour of the detekt Gradle plugin at all, just the detekt build itself.

Happy to switch back though if that makes sense when it comes to generating release notes.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #4576 (466a1ae) into main (1cc61fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4576   +/-   ##
=========================================
  Coverage     84.45%   84.45%           
  Complexity     3330     3330           
=========================================
  Files           479      479           
  Lines         11143    11143           
  Branches       2040     2040           
=========================================
  Hits           9411     9411           
  Misses          699      699           
  Partials       1033     1033           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc61fc...466a1ae. Read the comment docs.

@cortinico
Copy link
Member

I've updated the label to "housekeeping" since I thought the yellow labels, including "gradle", related to the named subprojects? This doesn't change behaviour of the detekt Gradle plugin at all, just the detekt build itself.

Yup that's better. I've initially added gradle as I expected some changes on some of our tasks. Give that there are none, it's safe to move to housekeeping

@3flex 3flex merged commit 7d87c80 into detekt:main Feb 9, 2022
Goooler pushed a commit to Goooler/detekt that referenced this pull request Feb 10, 2022
* Flag tasks known to be incompatible with Gradle's configuration cache

* Enable Gradle's configuration cache by default
@3flex 3flex mentioned this pull request Feb 13, 2022
@3flex 3flex deleted the gradle/7.4-configuration-cache branch April 2, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants