Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split rule documentation printer to improve testability #4578

Merged
merged 2 commits into from Feb 10, 2022

Conversation

marschwar
Copy link
Contributor

This improves the testability of the rule config printer in preparation of configuration items with value and reason (#3501).

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #4578 (45e0ce6) into main (7d87c80) will increase coverage by 0.00%.
The diff coverage is 93.87%.

❗ Current head 45e0ce6 differs from pull request most recent head 143a59b. Consider uploading reports for the commit 143a59b to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4578   +/-   ##
=========================================
  Coverage     84.45%   84.46%           
- Complexity     3330     3332    +2     
=========================================
  Files           479      481    +2     
  Lines         11143    11147    +4     
  Branches       2040     2040           
=========================================
+ Hits           9411     9415    +4     
  Misses          699      699           
  Partials       1033     1033           
Impacted Files Coverage Δ
...arturbosch/detekt/generator/printer/RulePrinter.kt 88.88% <88.88%> (ø)
...gitlab/arturbosch/detekt/generator/out/Markdown.kt 27.27% <100.00%> (+2.27%) ⬆️
...tekt/generator/printer/RuleConfigurationPrinter.kt 100.00% <100.00%> (ø)
...sch/detekt/generator/printer/RuleSetPagePrinter.kt 75.00% <100.00%> (-15.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d87c80...143a59b. Read the comment docs.

@marschwar marschwar added the housekeeping Marker for housekeeping tasks and refactorings label Feb 10, 2022
@cortinico cortinico added this to the 1.20.0 milestone Feb 10, 2022
@marschwar marschwar merged commit d50224e into detekt:main Feb 10, 2022
@marschwar marschwar deleted the config-printer branch February 10, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants