Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error classification in Gradle Enterprise. #4586

Merged
merged 4 commits into from Feb 19, 2022
Merged

Better error classification in Gradle Enterprise. #4586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c3c2fb
Better error classification in Gradle Enterprise.
runningcode Feb 16, 2022
cdc5511
Use Analysis failed instead of Lint failed
runningcode Feb 17, 2022
e8e0417
Fix failing test not using new artifact
runningcode Feb 18, 2022
c29ddea
Undo change to gradle build
runningcode Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions detekt-cli/src/test/kotlin/io/gitlab/arturbosch/detekt/cli/runners/RunnerSpec.kt
View file
Open in desktop
Expand Up @@ -271,7 +271,7 @@ class RunnerSpec {
fun `does fail via cli flag`() {
assertThatThrownBy { executeDetekt("--input", inputPath.toString(), "--max-issues", "0") }
.isExactlyInstanceOf(MaxIssuesReached::class.java)
.hasMessage("Build failed with 1 weighted issues.")
.hasMessage("Analysis failed with 1 weighted issues.")
}

@Test
Expand All @@ -286,7 +286,7 @@ class RunnerSpec {
"configs/max-issues--1.yml" // allow any
)
}.isExactlyInstanceOf(MaxIssuesReached::class.java)
.hasMessage("Build failed with 1 weighted issues.")
.hasMessage("Analysis failed with 1 weighted issues.")
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/config/MaxIssueCheck.kt
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ internal class MaxIssueCheck(

fun check(numberOfIssues: Int) {
if (!meetsPolicy(numberOfIssues)) {
throw MaxIssuesReached("Build failed with $numberOfIssues weighted issues.")
throw MaxIssuesReached("Analysis failed with $numberOfIssues weighted issues.")
}
}
}