Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error classification in Gradle Enterprise. #4586

Merged
merged 4 commits into from Feb 19, 2022
Merged

Better error classification in Gradle Enterprise. #4586

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c3c2fb
Better error classification in Gradle Enterprise.
runningcode Feb 16, 2022
cdc5511
Use Analysis failed instead of Lint failed
runningcode Feb 17, 2022
e8e0417
Fix failing test not using new artifact
runningcode Feb 18, 2022
c29ddea
Undo change to gradle build
runningcode Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/invoke/DetektInvoker.kt
View file
Open in desktop
Expand Up @@ -66,7 +66,7 @@ internal class DefaultCliInvoker(
}
}

private fun isBuildFailure(msg: String) = "Analysis failed with" in msg && "issues" in msg
private fun isBuildFailure(msg: String) = "Build failed with" in msg && "issues" in msg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cortinico I had to revert this change to the Gradle plugin since the failure detection would break. Is the Gradle plugin published together with the detekt-core artifact?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are 👍

}

private class DryRunInvoker(private val logger: Logger) : DetektInvoker {
Expand Down