Fix concurrency issue when creating PomModel (#4609) #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention that I endeavoured to create a test as well, but inherently, it'd slow down the test suite as it's not possible to deterministically trigger the issue without setting sync points in the production code. |
BraisGabin
approved these changes
Mar 14, 2022
|
Thanks for the approval! Who can merge? |
|
I want to give a bit of time to other maintainers to review. Otherwise in one or two days I'll merge it :) |
marschwar
approved these changes
Mar 17, 2022
davidburstromspotify
added a commit
to davidburstromspotify/detekt
that referenced
this pull request
Apr 4, 2022
davidburstromspotify
pushed a commit
to davidburstromspotify/detekt
that referenced
this pull request
Apr 4, 2022
davidburstromspotify
pushed a commit
to davidburstromspotify/detekt
that referenced
this pull request
Apr 9, 2022
davidburstromspotify
pushed a commit
to davidburstromspotify/detekt
that referenced
this pull request
Apr 9, 2022
davidburstromspotify
pushed a commit
to davidburstromspotify/detekt
that referenced
this pull request
Apr 9, 2022
davidburstromspotify
pushed a commit
to davidburstromspotify/detekt
that referenced
this pull request
May 29, 2022
BraisGabin
pushed a commit
that referenced
this pull request
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4609