Add ignoreOverridden support for BooleanPropertyNaming rule #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhernand40
force-pushed
the
add-ignore-overridden-support-for-boolean-property-naming-rule
branch
from
c794465
to
25b1ddb
Compare
mhernand40
force-pushed
the
add-ignore-overridden-support-for-boolean-property-naming-rule
branch
from
25b1ddb
to
e7a5566
Compare
cortinico
approved these changes
Mar 30, 2022
|
Great stuff 👍 |
BraisGabin
approved these changes
Mar 30, 2022
| @@ -35,6 +36,9 @@ class BooleanPropertyNaming(config: Config = Config.empty) : Rule(config) { | |||
| @Configuration("naming pattern") | |||
| private val allowedPattern: Regex by config("^(is|has|are)", String::toRegex) | |||
|
|
|||
| @Configuration("ignores properties that have the override modifier") | |||
| private val ignoreOverridden: Boolean by config(false) | |||
There was a problem hiding this comment.
I would default this to true. I know, this is to avoid behaviour change but for me this is more a bug fix than a "behaviour change".
There was a problem hiding this comment.
I'd be happy to address and make that change. Would others care to weigh in what their thoughts are before I do so? Thank you 🙂
There was a problem hiding this comment.
Agree, this is reasonable to be defaulted to true. Is a "bug-fix on steroids"
There was a problem hiding this comment.
Done. Thank you so much. 🙂
|
Thanks for the PR it looks great :) |
chao2zhang
pushed a commit
that referenced
this pull request
Apr 8, 2022
* Add ignoreOverridden support for BooleanPropertyNaming * Default to true for ignoreOverridden * Fix tests * Update default-detekt-config.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4652.