NonBooleanPropertyPrefixedWithIs: Allow boolean function reference #4684
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4684 +/- ##
============================================
- Coverage 84.58% 84.58% -0.01%
- Complexity 3434 3441 +7
============================================
Files 492 492
Lines 11329 11335 +6
Branches 2058 2061 +3
============================================
+ Hits 9583 9588 +5
Misses 701 701
- Partials 1045 1046 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks @kvn-stgl for the nice contribution!
May I ask you to correct the used code snippets in the tests, so that those two code snippets are actually valid Kotlin code. This repo runs compile checks on CI for snippets in tests. It would then make the CI green.
| val isDebuggable get() = BuildConfig.DEBUG | ||
| } | ||
| """ | ||
| val findings = subject.compileAndLintWithContext(env, code) |
There was a problem hiding this comment.
This one should be just lintWithContext. You doesn't want to compile it because it is meant to no compile.
There was a problem hiding this comment.
You're right. Thanks for the hint!
…4684) * NonBooleanPropertyPrefixedWithIs: Allow boolean function reference properties * fix detekt * replace compileAndLintWithContext with lintWithContext
This PR will allow boolean function reference properties for the NonBooleanPropertyPrefixedWithIs rule. (And fix issue #4675).
It also fixes a little issue that unknown types are not null, the string is just empty. This should also fix issue #4674.