Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.pinterest.ktlint to v0.45.2 #4690

Merged
merged 1 commit into from Apr 7, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 6, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.pinterest.ktlint:ktlint-ruleset-experimental 0.45.1 -> 0.45.2 age adoption passing confidence
com.pinterest.ktlint:ktlint-ruleset-standard 0.45.1 -> 0.45.2 age adoption passing confidence
com.pinterest.ktlint:ktlint-core 0.45.1 -> 0.45.2 age adoption passing confidence

Release Notes

pinterest/ktlint

v0.45.2

Compare Source

Fixed
Changed
  • Set Kotlin development version to 1.6.20 and Kotlin version to 1.6.20.

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #4690 (5adafdf) into main (8c68b78) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5adafdf differs from pull request most recent head 13bbd72. Consider uploading reports for the commit 13bbd72 to get more accurate results

@@             Coverage Diff              @@
##               main    #4690      +/-   ##
============================================
+ Coverage     84.44%   84.45%   +0.01%     
  Complexity     3436     3436              
============================================
  Files           492      492              
  Lines         11337    11335       -2     
  Branches       2083     2082       -1     
============================================
  Hits           9573     9573              
+ Misses          703      701       -2     
  Partials       1061     1061              
Impacted Files Coverage Δ
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <0.00%> (ø)
...gitlab/arturbosch/detekt/cli/ArgumentConverters.kt 75.00% <0.00%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c68b78...13bbd72. Read the comment docs.

@renovate renovate bot force-pushed the renovate/com.pinterest.ktlint branch 2 times, most recently from 437f0bb to 33d9eb4 Compare April 6, 2022 21:17
@cortinico
Copy link
Member

Do we want to include this into v1.20.0? CI is green but I havent' looked into the extend of this KtLint release

@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Apr 6, 2022
@renovate renovate bot force-pushed the renovate/com.pinterest.ktlint branch from 33d9eb4 to 5adafdf Compare April 6, 2022 22:55
@3flex
Copy link
Member

3flex commented Apr 7, 2022

Looks like it resolved some compatibility issues raised in 0.45.0, I read the associated issue and if we were affected by the issue (or something was fixed in the latest) I think we'd know about it already. I don't think there are any user facing changes compared to 0.45.1.

I don't think it matters if it's in or out for 1.20 - maybe exclude it and save the update for 1.21 just to avoid risk it breaks something new?

@cortinico
Copy link
Member

cortinico commented Apr 7, 2022

I don't think it matters if it's in or out for 1.20 - maybe exclude it and save the update for 1.21 just to avoid risk it breaks something new?

I was more for including this, as if there is anything critical, users will have to wait for a full release to get it + it's a point release

@renovate renovate bot force-pushed the renovate/com.pinterest.ktlint branch from 5adafdf to 13bbd72 Compare April 7, 2022 14:12
@cortinico cortinico added this to the 1.20.0 milestone Apr 7, 2022
@cortinico cortinico merged commit eed11a2 into main Apr 7, 2022
@cortinico cortinico deleted the renovate/com.pinterest.ktlint branch April 7, 2022 21:55
chao2zhang pushed a commit that referenced this pull request Apr 8, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants