Add failure message assertions to Gradle's "expect failure" tests #4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4693 +/- ##
=========================================
Coverage 84.45% 84.45%
Complexity 3436 3436
=========================================
Files 492 492
Lines 11335 11335
Branches 2082 2082
=========================================
Hits 9573 9573
Misses 701 701
Partials 1061 1061 Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Apr 7, 2022
cortinico
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #4687 I found some tests that should have failed after making changes, but didn't.
This is because some tests expected the Gradle job to fail, but didn't check the reason for the failure - so the test would be green even when it wasn't behaving correctly.
This PR adds failure message assertions when using
runDetektTaskAndExpectFailureorrunTasksAndExpectFailurewhere that was missing, and fixes a couple of tests that had problems in the specified build file that were found as a result.I considered adding a required string parameter to those two functions to ensure a message was always provided, which would be a way to avoid this in future, but that could be done separately if desired.