Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionalWhenBraces: fix false negative when the single statement has comments inside #4722

Merged
merged 1 commit into from Apr 17, 2022

Conversation

t-kameyama
Copy link
Contributor

Fixes #4715

@github-actions github-actions bot added the rules label Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #4722 (84accef) into main (583ab1e) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff            @@
##               main    #4722   +/-   ##
=========================================
  Coverage     84.71%   84.71%           
- Complexity     3423     3425    +2     
=========================================
  Files           490      490           
  Lines         11255    11256    +1     
  Branches       2069     2069           
=========================================
+ Hits           9535     9536    +1     
  Misses          675      675           
  Partials       1045     1045           
Impacted Files Coverage Δ
...rturbosch/detekt/rules/style/OptionalWhenBraces.kt 94.11% <75.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583ab1e...84accef. Read the comment docs.

@BraisGabin BraisGabin merged commit 683e696 into detekt:main Apr 17, 2022
@t-kameyama t-kameyama deleted the issue_4715 branch April 17, 2022 21:21
@cortinico cortinico added this to the 1.21.0 milestone Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptionalWhenBraces false negative
4 participants