UnnecessaryInnerClass: fix false positive with references to function type variables #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
pushed a commit
that referenced
this pull request
May 27, 2022
Add a unit test for a bug in which safe qualified references to a nullable field in the parent class (i.e. as `?.`) would not be marked as warnings in release 1.20.0. This issue has been inadvertently fixed by #4738, but adding a unit test will guard against future regressions. I was able to confirm this test fails by checking out the 1.20.0 tag and running the unit test; against that tag the fix was to override the visitSafeQualifiedExpression() function with the same logic as visitCallExpression().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4735