Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unnecesary @Nested #4740

Merged
merged 1 commit into from Apr 25, 2022
Merged

Remove Unnecesary @Nested #4740

merged 1 commit into from Apr 25, 2022

Conversation

BraisGabin
Copy link
Member

No description provided.

@BraisGabin
Copy link
Member Author

Once we merge this I will creta a PR adding the hash of that commit to .git-blame-ignore-revs to remove it from blame. https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

@3flex
Copy link
Member

3flex commented Apr 21, 2022

Did codecov provide a report? We'll want the coverage diff to be 0%... Not sure how closely anyone will review given the number of lines changed (!!)

@BraisGabin
Copy link
Member Author

To give context. To make this PR I implemented a new rule on my junit rule set and then I executed it over detekt until I fixed all the issues.

I did all the changes manually but in general all of them were to remove the first @Nested and reduce by one all the indentation.

I don't know if there is a way with github or git to ignore indentation changes. That way the review would be way easier.

@BraisGabin
Copy link
Member Author

I would appreciate to have fast feeback on this PR. If you think that it shouldn't be merged I can close it. But this PR will get a lot of conflicts so I would like to take a decission about it asap.

cortinico
cortinico approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I'd love to merge it. I got enticed away form the big diff size 😅

I checked a couple of files and it looks good to me. I trust the CI at this stage ¯_(ツ)_/¯

@cortinico cortinico added housekeeping Marker for housekeeping tasks and refactorings and removed rules api core cli gradle-plugin formatting labels Apr 25, 2022
@cortinico cortinico added this to the 1.21.0 milestone Apr 25, 2022
@vercel
Copy link

vercel bot commented Apr 25, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
detekt ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 8:36PM (UTC)

@BraisGabin BraisGabin removed the rules label Apr 25, 2022
@BraisGabin BraisGabin merged commit a2734b1 into main Apr 25, 2022
@BraisGabin BraisGabin deleted the remove-nested branch April 25, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BraisGabin @3flex @cortinico