Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure flakyness on Windows CI #4742

Merged
merged 1 commit into from Jun 22, 2022
Merged

Measure flakyness on Windows CI #4742

merged 1 commit into from Jun 22, 2022

Conversation

BraisGabin
Copy link
Member

We all know that our Windows & JDK11 CI is flaky. It show flakyness. Here I have a list of 8 failed builds because of that:

We had this problem already with Windows & JDK8 and we "fixed" it by disabling that combination: #4403

Right now we don't have flakyness information on of Gradle enterprise instance https://ge.detekt.dev/scans/tests because we need to activate this plugin: https://docs.gradle.com/enterprise/flaky-test-detection/

That's what this PR does, add that plugin. I don't like the idea of "retry" tests but I think that this is the only option that we have right now.

Open question: Should I enable it only for Windows?

@github-actions github-actions bot added the build label Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #4742 (a98bb56) into main (a51adb8) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head a98bb56 differs from pull request most recent head bde4400. Consider uploading reports for the commit bde4400 to get more accurate results

@@             Coverage Diff              @@
##               main    #4742      +/-   ##
============================================
- Coverage     84.74%   84.69%   -0.05%     
+ Complexity     3431     3418      -13     
============================================
  Files           491      490       -1     
  Lines         11270    11235      -35     
  Branches       2074     2068       -6     
============================================
- Hits           9551     9516      -35     
- Misses          673      675       +2     
+ Partials       1046     1044       -2     
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/cli/ArgumentConverters.kt 69.23% <0.00%> (-4.11%) ⬇️
...les/style/ExplicitCollectionElementAccessMethod.kt 63.63% <0.00%> (-3.04%) ⬇️
...lab/arturbosch/detekt/rules/style/UnusedImports.kt 87.34% <0.00%> (-2.54%) ⬇️
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 79.16% <0.00%> (-2.47%) ⬇️
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 88.70% <0.00%> (-1.62%) ⬇️
...turbosch/detekt/rules/complexity/NamedArguments.kt 82.14% <0.00%> (-1.20%) ⬇️
...lab/arturbosch/detekt/rules/style/VarCouldBeVal.kt 80.41% <0.00%> (-1.15%) ⬇️
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.50% <0.00%> (-0.15%) ⬇️
...arturbosch/detekt/generator/printer/RulePrinter.kt 100.00% <0.00%> (ø)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045928b...bde4400. Read the comment docs.

Copy link
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

detekt-gradle-plugin/build.gradle.kts Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
detekt ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 7:29AM (UTC)

@chao2zhang
Copy link
Member

Let's monitor Gradle enterprise / Test when this is merged. If this pipeline works, GE is an actual savior for monitoring and tackling test flakiness without manual CI scripting.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Jun 22, 2022
@BraisGabin BraisGabin merged commit 8dc783a into main Jun 22, 2022
@BraisGabin BraisGabin deleted the flakyness branch June 22, 2022 16:32
@BraisGabin BraisGabin added this to the 1.21.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants