Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suspend lambda rule with CoroutineScope receiver due to not de… #4747

Merged
merged 1 commit into from Apr 24, 2022
Merged

Remove suspend lambda rule with CoroutineScope receiver due to not de… #4747

merged 1 commit into from Apr 24, 2022

Conversation

hfhbd
Copy link
Contributor

@hfhbd hfhbd commented Apr 22, 2022

@github-actions github-actions bot added the rules label Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #4747 (9797db9) into main (7960453) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4747      +/-   ##
============================================
- Coverage     84.69%   84.69%   -0.01%     
+ Complexity     3418     3411       -7     
============================================
  Files           490      490              
  Lines         11235    11224      -11     
  Branches       2068     2065       -3     
============================================
- Hits           9516     9506      -10     
  Misses          675      675              
+ Partials       1044     1043       -1
Impacted Files Coverage Δ
...coroutines/SuspendFunWithCoroutineScopeReceiver.kt 80.00% <ø> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7960453...9797db9. Read the comment docs.

BraisGabin
BraisGabin approved these changes Apr 23, 2022
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the research.

@cortinico cortinico added this to the 1.21.0 milestone Apr 24, 2022
schalkms
schalkms reviewed Apr 24, 2022
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything to update in the rule doc due to this behavioral change?
Otherwise, I'd say LGTM.

@hfhbd
Copy link
Contributor Author

hfhbd commented Apr 24, 2022

@schalkms Nope, the lambda behavior wasn't documented :D

@BraisGabin BraisGabin merged commit 92ab17d into detekt:main Apr 24, 2022
@hfhbd hfhbd deleted the removeSuspendCoroutineScopeLambdaRule branch April 24, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms left review comments

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Remove suspend lambda parameter with CoroutineScope receiver rule
4 participants
@hfhbd @BraisGabin @cortinico @schalkms