Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-inspect the detekt-gradle-plugin #4765

Merged
merged 1 commit into from Apr 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions detekt-gradle-plugin/build.gradle.kts
Expand Up @@ -7,6 +7,8 @@ plugins {
`java-test-fixtures`
idea
alias(libs.plugins.pluginPublishing)
// We use this published version of the Detekt plugin to self analyse this project.
id("io.gitlab.arturbosch.detekt") version "1.20.0"
}

repositories {
Expand All @@ -17,6 +19,13 @@ repositories {
group = "io.gitlab.arturbosch.detekt"
version = Versions.currentOrSnapshot()

detekt {
source.from("src/functionalTest/kotlin")
buildUponDefaultConfig = true
baseline = file("config/gradle-plugin-baseline.xml")
config = files("config/gradle-plugin-detekt.yml")
}

testing {
suites {
getByName("test", JvmTestSuite::class) {
Expand Down Expand Up @@ -70,6 +79,9 @@ dependencies {

pluginCompileOnly(libs.android.gradle)
pluginCompileOnly(libs.kotlin.gradle)

// We use this published version of the detekt-formatting to self analyse this project.
detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.20.0")
}

gradlePlugin {
Expand Down
6 changes: 6 additions & 0 deletions detekt-gradle-plugin/config/gradle-plugin-baseline.xml
@@ -0,0 +1,6 @@
<?xml version="1.0" ?>
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
</CurrentIssues>
</SmellBaseline>
35 changes: 35 additions & 0 deletions detekt-gradle-plugin/config/gradle-plugin-detekt.yml
@@ -0,0 +1,35 @@
complexity:
TooManyFunctions:
excludes: ["**/test/**", "**/functionalTest/**"]

naming:
ClassNaming:
excludes: ["**/*Spec.kt"]
FunctionNaming:
active: true
excludes:
- "**/test/**"
- "**/androidTest/**"
- "**/commonTest/**"
- "**/functionalTest/**"
- "**/jvmTest/**"
- "**/jsTest/**"
- "**/iosTest/**"

performance:
SpreadOperator:
excludes: ["**/test/**", "**/functionalTest/**"]

style:
MagicNumber:
active: true
excludes: ["**/test/**", "**/*Test.kt", "**/*Spec.kt"]
MaxLineLength:
active: true
excludes: ["**/test/**", "**/*Test.kt", "**/*Spec.kt"]
excludeCommentStatements: true

formatting:
active: true
MaximumLineLength:
active: false