Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially drop redundant usage of "dry run" in Gradle plugin tests #4776

Merged
merged 5 commits into from Apr 26, 2022
Merged

Partially drop redundant usage of "dry run" in Gradle plugin tests #4776

merged 5 commits into from Apr 26, 2022

Conversation

3flex
Copy link
Member

@3flex 3flex commented Apr 26, 2022 •
edited

See #3778. I'll tackle this over a set of smaller PRs.

Highlights in this one:

  • introducing a helper to make testing task dependencies simpler when using ProjectBuilder for testing
  • using one of the helpers when migrating DetektPlainSpec to use ProjectBuilder instead of TestKit
  • moving away from dry run tests for functional tests where the use of dry run doesn't provide any specific benefits

@3flex 3flex merged commit 3e062df into detekt:main Apr 26, 2022
@3flex 3flex deleted the dry-run branch April 26, 2022 23:00
@cortinico cortinico added this to the 1.21.0 milestone Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
gradle-plugin
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@3flex @cortinico @schalkms