Add dependency-analysis plugin and implement some recommendations #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used widely in the project, but don't indicate a problem that would affect library consumers. Disabling will reduce number of reports.
dependency-analysis recommends changing configuration from "implementation" to "api" since plugins expose detekt-api classes. "compileOnly" is more appropriate as detekt provides detekt-api on the classpath in the environment that the plugin runs in. This also make things consistent with detekt-report-sarif, detekt-report-html, and the various rule sets.
dependency-analysis plugin will otherwise report sarif4k as an "api" dependency which is incorrect.
github-actions
bot
added
build
dependencies
Codecov Report
@@ Coverage Diff @@
## main #4798 +/- ##
=========================================
Coverage 84.80% 84.80%
Complexity 3480 3480
=========================================
Files 494 494
Lines 11395 11395
Branches 2105 2105
=========================================
Hits 9664 9664
Misses 676 676
Partials 1055 1055
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
May 1, 2022
cortinico
approved these changes
May 1, 2022
cortinico
approved these changes
May 16, 2022
schalkms
approved these changes
Jun 1, 2022
cortinico
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details. These issues are reported by the
:buildHealthtask.Not all issues reported by that task were addressed, for various reasons, but these changes seemed sane.