Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler spec type mismatch #4800

Closed
wants to merge 1 commit into from

Conversation

rocketraman
Copy link
Contributor

Hopefully fixes #4786 .

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #4800 (007dfc5) into main (16bbc16) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #4800   +/-   ##
=========================================
  Coverage     84.70%   84.71%           
  Complexity     3426     3426           
=========================================
  Files           491      491           
  Lines         11253    11252    -1     
  Branches       2069     2068    -1     
=========================================
  Hits           9532     9532           
  Misses          676      676           
+ Partials       1045     1044    -1     
Impacted Files Coverage Δ
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 88.70% <100.00%> (ø)
...rturbosch/detekt/core/settings/EnvironmentAware.kt 72.22% <100.00%> (+3.80%) ⬆️
...o/github/detekt/tooling/dsl/CompilerSpecBuilder.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bbc16...007dfc5. Read the comment docs.

@BraisGabin
Copy link
Member

This is a breaking change (I'm not sure if we can assume it or not). And this seems related with #4801.

@cortinico
Copy link
Member

I'll hold off on this one till we find what's the root cause for #4786

@3flex
Copy link
Member

3flex commented Jun 19, 2022

Closing as we have resolved the original issue, and have a more robust approach to managing the embeddable compiler dependency going forward, which will hopefully avoid the issue occurring again.

@3flex 3flex closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JVM 17 & Kotlin 1.6.x Support
4 participants