Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GE enterprise 3.10 #4802

Merged
merged 2 commits into from May 3, 2022
Merged

Upgrade to GE enterprise 3.10 #4802

merged 2 commits into from May 3, 2022

Conversation

chao2zhang
Copy link
Member

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #4802 (0ceb981) into main (16bbc16) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4802   +/-   ##
=========================================
  Coverage     84.70%   84.71%           
  Complexity     3426     3426           
=========================================
  Files           491      491           
  Lines         11253    11256    +3     
  Branches       2069     2069           
=========================================
+ Hits           9532     9535    +3     
  Misses          676      676           
  Partials       1045     1045           
Impacted Files Coverage Δ
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.65% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bbc16...0ceb981. Read the comment docs.

@3flex
Copy link
Member

3flex commented May 3, 2022

I'm not opposed, as long as someone remembers to update it from time to time - Renovate bot doesn't check versions in the settings file. That's why using the default version from Gradle itself made sense, because the wrapper is updated regularly, and Gradle updates the GE plugin version in new Gradle releases.

@chao2zhang
Copy link
Member Author

I should have given more context: This is an explicit request from the Gradle team (I assume they want to use detekt to stress test their new versions).

@chao2zhang
Copy link
Member Author

Linking back to the comment #4691 (comment)

@3flex
Copy link
Member

3flex commented May 3, 2022

Where did Gradle Inc. specifically request we don't fall behind? Didn't see it mentioned in that comment you linked. If the request came through other channels then that's OK too.

If it's that important to them then maybe they'll raise PRs when new versions of the plugin are released :)

@chao2zhang
Copy link
Member Author

GE 3.10 is coming with Gradle 7.5, which is not released yet. They asked to upgrade the GE plugin version ahead of Gradle. The linked comment was their acknowledgment of the fact that we preferred not to pin the version, but they still asked for pinning the GE version ahead of Gradle.

@chao2zhang chao2zhang merged commit 84ac72e into main May 3, 2022
@chao2zhang chao2zhang deleted the chao/geupgrade branch May 3, 2022 05:18
@cortinico cortinico added this to the 1.21.0 milestone May 3, 2022
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants