Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseOrEmpty: fix false positive for indexing operator calls with type parameters #4804

Merged
merged 2 commits into from May 5, 2022

Conversation

t-kameyama
Copy link
Contributor

Fix for #4791

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #4804 (46e5d12) into main (16bbc16) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #4804      +/-   ##
============================================
- Coverage     84.70%   84.70%   -0.01%     
- Complexity     3426     3429       +3     
============================================
  Files           491      491              
  Lines         11253    11266      +13     
  Branches       2069     2074       +5     
============================================
+ Hits           9532     9543      +11     
+ Misses          676      674       -2     
- Partials       1045     1049       +4     
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/rules/style/UseOrEmpty.kt 74.07% <50.00%> (-3.01%) ⬇️
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.65% <0.00%> (+0.14%) ⬆️
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 90.32% <0.00%> (+1.61%) ⬆️
...gitlab/arturbosch/detekt/cli/ArgumentConverters.kt 73.33% <0.00%> (+4.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bbc16...46e5d12. Read the comment docs.

@cortinico cortinico added this to the 1.21.0 milestone May 3, 2022
@BraisGabin
Copy link
Member

Thanks! We had multiples cases here :)

@BraisGabin BraisGabin merged commit da0c924 into detekt:main May 5, 2022
@t-kameyama t-kameyama deleted the issue_4791_2 branch May 5, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants