Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Display dynamic --jvm-target values when using --help flag (#4694)" #4816

Merged
merged 1 commit into from Jun 1, 2022

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 7, 2022

This reverts commit 7c903c5.

Fixes #4786

@3flex 3flex requested a review from cortinico May 7, 2022 03:24
@github-actions github-actions bot added the cli label May 7, 2022
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #4816 (18a176b) into main (d0d34c1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4816      +/-   ##
============================================
+ Coverage     84.71%   84.72%   +0.01%     
  Complexity     3431     3431              
============================================
  Files           491      491              
  Lines         11267    11263       -4     
  Branches       2075     2074       -1     
============================================
- Hits           9545     9543       -2     
+ Misses          673      672       -1     
+ Partials       1049     1048       -1     
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/cli/ArgumentConverters.kt 76.92% <ø> (+3.58%) ⬆️
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <100.00%> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 90.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d34c1...18a176b. Read the comment docs.

@3flex
Copy link
Member Author

3flex commented May 7, 2022

@cortinico suggest merging then releasing 1.20.1.

I'll open a new issue that covers the actual root cause, and we can look to a more appropriate solution for ensuring the correct compiler version is used by detekt and cannot be overridden.

Edit: Opened #4817

@cortinico
Copy link
Member

Just want to cross check with everyone that we cosnider this worth publishing a point release.

@cortinico cortinico added this to the 1.21.0 milestone May 8, 2022
@cortinico
Copy link
Member

@3flex Think will land in 1.21 as I don't think we need to do a point release just for this. Please let me know if this is not the case.

@cortinico cortinico merged commit 80bae4b into detekt:main Jun 1, 2022
@3flex 3flex deleted the 4694-revert branch December 4, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JVM 17 & Kotlin 1.6.x Support
3 participants