UnnecessaryInnerClass: fix false positives labeled expression to outer class #4865
+71
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r class Fix an issue where inner classes which reference their outer class via a labeled expression would still be reported as unnecessary. This seems to be due to a missing visitExpressionWithLabel() check which resolves the label name: if the label is referencing a parent class, then the nested class must be `inner`. I wasn't able to find a way to resolve the labeled expression as a ClassId to match the existing class check from KtReferenceExpression, so I settled for using the class name instead, which is easy to obtain. This means there's a fair bit of duplication in overriden checkForOuterUsage() methods to check parent classes which could probably be removed, but I didn't see a particularly clean way to do so.
Codecov Report
@@ Coverage Diff @@
## main #4865 +/- ##
=========================================
Coverage 84.79% 84.80%
- Complexity 3447 3452 +5
=========================================
Files 492 492
Lines 11315 11326 +11
Branches 2083 2086 +3
=========================================
+ Hits 9595 9605 +10
Misses 673 673
- Partials 1047 1048 +1
Continue to review full report at Codecov.
|
schalkms
reviewed
May 27, 2022
...rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryInnerClass.kt
Show resolved
Hide resolved
… labeled expressions
schalkms
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where inner classes which reference their outer class via a labeled
expression would still be reported as unnecessary. This seems to be due to a
missing visitExpressionWithLabel() check which resolves the label name: if the
label is referencing a parent class, then the nested class must be
inner.I wasn't able to find a way to resolve the labeled expression as a ClassId to
match the existing class check from KtReferenceExpression, so I settled for
using the class name instead, which is easy to obtain. This means there's a fair
bit of duplication in overriden checkForOuterUsage() methods to check parent
classes which could probably be removed, but I didn't see a particularly clean
way to do so.