Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReturnCount debt and refactor code #5026

Merged
merged 3 commits into from Jul 1, 2022
Merged

Fix ReturnCount debt and refactor code #5026

merged 3 commits into from Jul 1, 2022

Conversation

amitdash291
Copy link
Contributor

This PR achieves the following:

  1. Fix ReturnCount debt in UnnecessaryBackticks
  2. Remove code duplication in NullableBooleanCheck

@github-actions github-actions bot added the rules label Jul 1, 2022
@schalkms schalkms merged commit ddcf77d into detekt:main Jul 1, 2022
@amitdash291 amitdash291 deleted the fix-return-count-debt branch July 1, 2022 20:30
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the change in the backtick rule improves the readability.

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jul 5, 2022
@cortinico cortinico added this to the 1.21.0 milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants