Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement
MultilineRawStringIndentation
#5058Implement
MultilineRawStringIndentation
#5058Changes from all commits
03d5fce
52988e9
4d0cc56
1d43784
33a46d2
59b6e53
ab9ab07
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually want to report one violation for each line that is incorrectly indented? Consider a code block like in detekt tests. If you get the indentation wrong, it is most likely wrong for entire block. Would it not be enough to mark the multi line string as a violation as a whole? That most likely would make the rule much easier to implement.
Specifically I do not like the fact that
produces 2 violations, while
produces one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes... this was a difficult decission. I was thinking about a long raw string with only one/few lines with the wrong identation. In that case I wanted to point out exactly which line was the wrong one. The problem is that if all of them are wrong I end up raising all of them
The second case was easy because if it happens I know that all the lines are wrong so I just raise the error once.
I feel that this is a tradeoff:
🤷 I'm fine with both of them to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I think the code could have been easier to write and to maintain if it were just one violation per multi line string, but I see your point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging it like this. We can always revisit this once we get the users feedback.