Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ForbiddenMethodCall to support property getters/setters and method references #5078

Merged
merged 3 commits into from Jul 18, 2022
Merged

Make ForbiddenMethodCall to support property getters/setters and method references #5078

merged 3 commits into from Jul 18, 2022

Conversation

pinguinjkeke
Copy link
Contributor

Closes #5015

@github-actions github-actions bot added the rules label Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022 •
edited

Codecov Report

Merging #5078 (8654a96) into main (6bce28f) will increase coverage by 0.01%.
The diff coverage is 90.90%.

❗ Current head 8654a96 differs from pull request most recent head 501b516. Consider uploading reports for the commit 501b516 to get more accurate results

@@             Coverage Diff              @@
##               main    #5078      +/-   ##
============================================
+ Coverage     84.87%   84.88%   +0.01%     
- Complexity     3575     3581       +6     
============================================
  Files           500      500              
  Lines         11785    11795      +10     
  Branches       2197     2199       +2     
============================================
+ Hits          10002    10012      +10     
+ Misses          692      691       -1     
- Partials       1091     1092       +1
Impacted Files Coverage Δ
...turbosch/detekt/rules/style/ForbiddenMethodCall.kt 91.11% <90.90%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bce28f...501b516. Read the comment docs.

BraisGabin
BraisGabin approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BraisGabin
Copy link
Member

You have code snippets that doesn't compile. More info about this here #4874

@BraisGabin BraisGabin added this to the 1.22.0 milestone Jul 18, 2022
@BraisGabin BraisGabin merged commit 2ac718f into detekt:main Jul 18, 2022
VitalyVPinchuk pushed a commit to VitalyVPinchuk/detekt that referenced this pull request Jul 25, 2022
@pinguinjkeke @VitalyVPinchuk
Make ForbiddenMethodCall to support property getters/setters and meth…
c46a634 
…od references (detekt#5078)

* Make ForbiddenMethodCall to handle getters and setters.

* Make ForbiddenMethodCall to support callable references.

* Fix test snippets.

Co-authored-by: Alexander Avakov <alexander.avakov@nordigy.ru>
@cortinico cortinico mentioned this pull request Oct 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

ForbiddenMethodCall with Kotlin getters as property
2 participants
@pinguinjkeke @BraisGabin