Support proper globbing in ReturnCount
#5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5118 +/- ##
============================================
- Coverage 84.91% 84.91% -0.01%
- Complexity 3613 3614 +1
============================================
Files 502 502
Lines 11884 11889 +5
Branches 2236 2239 +3
============================================
+ Hits 10091 10095 +4
Misses 690 690
- Partials 1103 1104 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
marschwar
approved these changes
Jul 29, 2022
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/ReturnCount.kt
Outdated
Show resolved
Hide resolved
cortinico
approved these changes
Jul 30, 2022
detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ReturnCountSpec.kt
Outdated
Show resolved
Hide resolved
…/rules/style/ReturnCount.kt Co-authored-by: marschwar <marschwar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitPatternhas a partial/funky support for glob patterns. This PR changes that to a proper implementation usingsimplePatternToRegex.