Use list config for FunctionOnlyReturningConstant>excludedFunctions
#5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
use-config-list-FunctionOnlyReturningConstant
branch
from
9206311
to
f997f62
Compare
Codecov Report
@@ Coverage Diff @@
## main #5120 +/- ##
============================================
- Coverage 84.97% 84.96% -0.01%
Complexity 3638 3638
============================================
Files 502 502
Lines 11971 11972 +1
Branches 2258 2259 +1
============================================
Hits 10172 10172
Misses 689 689
- Partials 1110 1111 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BraisGabin
force-pushed
the
use-config-list-FunctionOnlyReturningConstant
branch
from
f997f62
to
21ea124
Compare
marschwar
approved these changes
Jul 29, 2022
Comment on lines
+75
to
+76
| val code = "fun f() = 1" | ||
| val config = TestConfig(mapOf(EXCLUDED_FUNCTIONS to listOf("f"))) |
There was a problem hiding this comment.
Should this be something utilizing wildcards?
There was a problem hiding this comment.
I added a new test for that.
...yle/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/FunctionOnlyReturningConstant.kt
Outdated
Show resolved
Hide resolved
BraisGabin
force-pushed
the
use-config-list-FunctionOnlyReturningConstant
branch
from
21ea124
to
c8830e0
Compare
…/rules/style/FunctionOnlyReturningConstant.kt Co-authored-by: marschwar <marschwar@users.noreply.github.com>
cortinico
removed
the
notable changes
|
I won't mention this in the notable changes as the list is getting quite long. Should I add a paragraph in the migration section of the changelog? |
Follow up for @arturbosch here: it seems we need this info in the changelog then 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.