- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't exclude tests in WildcardImport Rule #5121
Conversation
9ce51ab
to
d323bc3
Compare
d323bc3
to
fc5b7c0
Compare
...test/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/ConfigPrinterSpec.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #5121 +/- ##
===========================================
+ Coverage 0 84.92% +84.92%
- Complexity 0 3614 +3614
===========================================
Files 0 502 +502
Lines 0 11886 +11886
Branches 0 2237 +2237
===========================================
+ Hits 0 10094 +10094
- Misses 0 689 +689
- Partials 0 1103 +1103
Continue to review full report at Codecov.
|
fc5b7c0
to
315b298
Compare
315b298
to
96e3355
Compare
This looks like it has #5130 mixed in, I'm guessing that was unintentional and that this should be focused only on the update to remove the exclusion for test sources and fix the new issues that are reported? |
… if you don't want them in your production code
96e3355
to
3feb39f
Compare
You are right. I have far too many open branches right now >_< |
I've tagged it as a notable change because some users will get new issues reported if they're using the default config. |
Context: #5116 (comment)
This PR is also kind of "housekeeping" because I remove the
'java.util.*'
as a valid Wildcard import as we have in the default values.