Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SimpleGlob in favor of String.simplePatternToRegex() #5144

Merged
merged 1 commit into from Jul 29, 2022
Merged

remove SimpleGlob in favor of String.simplePatternToRegex() #5144

merged 1 commit into from Jul 29, 2022

Conversation

marschwar
Copy link
Contributor

This removes the SimpleGlob type which does essentially the same
as the String.simplePatternToRegex() extension function.

'?' matches any one character

I changed the implementation to match the documentation.

@marschwar marschwar added housekeeping Marker for housekeeping tasks and refactorings and removed rules labels Jul 28, 2022
BraisGabin
BraisGabin approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marschwar marschwar merged commit 0d6f790 into detekt:main Jul 29, 2022
@marschwar marschwar deleted the chore/remove-simple-glob branch July 29, 2022 11:11
@cortinico cortinico added this to the 1.22.0 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
api housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marschwar @BraisGabin @cortinico