Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable warnings as errors for detekt-gradle-plugin #5155

Merged
merged 1 commit into from Aug 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions build-logic/src/main/kotlin/module.gradle.kts
Expand Up @@ -56,12 +56,7 @@ tasks.withType<KotlinCompile>().configureEach {
"-progressive",
"-Xsuppress-version-warnings",
)
// Note: Currently there are warnings for detekt-gradle-plugin that seemingly can't be fixed
// until Gradle releases an update (https://github.com/gradle/gradle/issues/16345)
allWarningsAsErrors = when (project.name) {
"detekt-gradle-plugin" -> false
else -> project.findProperty("warningsAsErrors") == "true"
}
allWarningsAsErrors = project.findProperty("warningsAsErrors") == "true"
}
}

Expand Down
@@ -1,3 +1,5 @@
@file:Suppress("DEPRECATION")

package io.gitlab.arturbosch.detekt.internal

import com.android.build.gradle.AppExtension
Expand Down
@@ -1,3 +1,5 @@
@file:Suppress("DEPRECATION")

package io.gitlab.arturbosch.detekt.internal

import io.gitlab.arturbosch.detekt.DetektPlugin
Expand Down
Expand Up @@ -12,6 +12,7 @@ internal fun Project.registerDetektTask(
configuration: Detekt.() -> Unit
): TaskProvider<Detekt> =
tasks.register(name, Detekt::class.java) {
@Suppress("DEPRECATION")
with(extension.reports) {
if (xml.outputLocation.isPresent) {
logger.warn(
Expand Down