Fix errors with detektGenerateConfig
#5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektGenerateConfigTask.kt
Fixed
Show fixed
Hide fixed
chao2zhang
approved these changes
Aug 7, 2022
Comment on lines
+47
to
53
| private val configurationToUse: File | ||
| get() = if (config.isEmpty) { | ||
| objects.fileCollection().from(defaultConfigPath) | ||
| defaultConfigPath.toFile() | ||
| } else { | ||
| config | ||
| config.last() | ||
| } | ||
|
|
There was a problem hiding this comment.
Just to confirm that these changes are mainly for refactoring.
schalkms
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recomment to read #4843 to understand all the context for this solution.
TL;DR
detektGenerateConfigruns in a race condition and tries to create the same file multiple times and crashes. With this solution we ansure that this task is always run in serial to avoid it.This PR also have 2 commits with little refactors over
DetektGenerateConfigTask. I didn't want to fall into the rabbit hole so I didn't refactor anymore. But if someone wants: It seems that we are doing more work than needed here. The providers and properties are executed multiple times without, I think, a good reason.Fixes #4843