Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all rules from EmptyBlocks multi rule individually #5208

Merged
merged 2 commits into from Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view

This file was deleted.

Expand Up @@ -17,7 +17,21 @@ class EmptyCodeProvider : DefaultRuleSetProvider {
override fun instance(config: Config): RuleSet = RuleSet(
ruleSetId,
listOf(
EmptyBlocks(config)
EmptyCatchBlock(config),
EmptyClassBlock(config),
EmptyDefaultConstructor(config),
EmptyDoWhileBlock(config),
EmptyElseBlock(config),
EmptyFinallyBlock(config),
EmptyForBlock(config),
EmptyFunctionBlock(config),
EmptyIfBlock(config),
EmptyInitBlock(config),
EmptyKtFile(config),
EmptySecondaryConstructor(config),
EmptyTryBlock(config),
EmptyWhenBlock(config),
EmptyWhileBlock(config),
)
)
}

This file was deleted.

Expand Up @@ -130,6 +130,12 @@ class EmptyCodeSpec {
test { EmptySecondaryConstructor(Config.empty) }
}

@Test
fun `reports an empty kt file`() {
val rule = EmptyKtFile(Config.empty)
assertThat(rule.compileAndLint("")).hasSize(1)
}

@Test
fun `doesNotFailWithInvalidRegexWhenDisabled`() {
val configValues = mapOf(
Expand Down
30 changes: 0 additions & 30 deletions detekt-rules-empty/src/test/resources/deactivated-empty-blocks.yml

This file was deleted.