Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnusedPrivateMember: fix false positive with backtick parameters #5252

Merged
merged 1 commit into from Aug 29, 2022
Merged

UnusedPrivateMember: fix false positive with backtick parameters #5252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt
View file
Open in desktop
Expand Up @@ -258,7 +258,7 @@ private class UnusedParameterVisitor(allowedNames: Regex) : UnusedMemberVisitor(
}

override fun visitReferenceExpression(expression: KtReferenceExpression) {
parameters.remove(expression.text)
parameters.remove(expression.text.removeSurrounding("`"))
super.visitReferenceExpression(expression)
}
})
Expand Down
11 changes: 11 additions & 0 deletions ...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt
View file
Open in desktop
Expand Up @@ -1468,6 +1468,17 @@ class UnusedPrivateMemberSpec(val env: KotlinCoreEnvironment) {
}
}

@Nested
inner class `backtick identifiers - #5251` {
@Test
fun `does not report used backtick parameters`() {
val code = """
fun test(`foo bar`: Int) = `foo bar`
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}
}

@Nested
inner class `list get overloaded operator function - #3640` {
@Test
Expand Down