New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detektVersionReplace.js plugin is not replacing all [detekt_version] tags on website #5266

Merged

BraisGabin merged 1 commit into detekt:main from Ridje:patch-1

Sep 4, 2022

Commits on Sep 1, 2022

Fix issue with not some wrong commands

There is error on https://detekt.dev/docs/gettingstarted/cli/ page.

instead of `curl -sSLO https://github.com/detekt/detekt/releases/download/v1.21.0/detekt-cli-1.21.0.zip
unzip detekt-cli-1.21.0.zip
./detekt-cli-1.21.0/bin/detekt-cli --help` it shows 'curl -sSLO https://github.com/detekt/detekt/releases/download/v1.21.0/detekt-cli-[detekt_version].zip
unzip detekt-cli-[detekt_version].zip
./detekt-cli-[detekt_version]/bin/detekt-cli --help' command.
I suppose this issue is happening because detekt plugin uses 'replace' in node instead of 'replaceAll'.
Or I can also suggest to use `do while` instead of `if` block.

Ridje committed Sep 1, 2022