Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unnecessary suppressions #5400

Merged
merged 2 commits into from Oct 10, 2022
Merged

Remove some unnecessary suppressions #5400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff0dbde
Remove @Suppress("DEPRECATION") as DataFlowValueFactoryImpl is not de…
TWiStErRob Oct 10, 2022
558e559
Remove @Suppress("unused") as everything is used many times.
TWiStErRob Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt
View file
Open in desktop
@@ -1,5 +1,3 @@
@file:Suppress("unused")

package io.gitlab.arturbosch.detekt.api

import io.gitlab.arturbosch.detekt.api.internal.EmptyConfig
Expand Down
1 change: 0 additions & 1 deletion ...est/kotlin/io/gitlab/arturbosch/detekt/rules/style/RedundantVisibilityModifierRuleSpec.kt
View file
Open in desktop
Expand Up @@ -197,7 +197,6 @@ class RedundantVisibilityModifierRuleSpec {
hint(ExplicitApiMode::class)
languageVersionSettings.getFlag(AnalysisFlags.explicitApiMode)
} returns mode
@Suppress("DEPRECATION")
return CompilerResources(languageVersionSettings, DataFlowValueFactoryImpl(languageVersionSettings))
}

Expand Down
1 change: 0 additions & 1 deletion detekt-test/src/main/kotlin/io/gitlab/arturbosch/detekt/test/RuleExtensions.kt
View file
Open in desktop
Expand Up @@ -46,7 +46,6 @@ fun BaseRule.lintWithContext(
val bindingContext = environment.getContextForPaths(listOf(ktFile) + additionalKtFiles)
val languageVersionSettings = environment.configuration.languageVersionSettings

@Suppress("DEPRECATION")
val dataFlowValueFactory = DataFlowValueFactoryImpl(languageVersionSettings)
val compilerResources = CompilerResources(languageVersionSettings, dataFlowValueFactory)
return findingsAfterVisit(ktFile, bindingContext, compilerResources)
Expand Down