Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ruleauthors rule for Entity.from(x.nameIdentifier ?: x) -> Entity.atName(x) #5444

Merged
merged 11 commits into from Oct 25, 2022
Merged

New ruleauthors rule for Entity.from(x.nameIdentifier ?: x) -> Entity.atName(x) #5444

merged 11 commits into from Oct 25, 2022

Commits on Oct 19, 2022

  1. Add new rule UseNamedLocation

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    901a2fa View commit details
    Browse the repository at this point in the history

  2. Implement rule UseNamedLocation

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    4f64190 View commit details
    Browse the repository at this point in the history

  3. Ignore multi-arg overload

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    a72257c View commit details
    Browse the repository at this point in the history

  4. Highlight method name instead of whole expression.

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    31dc241 View commit details
    Browse the repository at this point in the history

  5. Test for message, and give a nice message.

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    6661975 View commit details
    Browse the repository at this point in the history

  6. Fix findings in Detekt codebase: 

    detekt-rules-libraries\src\main\kotlin\io\gitlab\arturbosch\detekt\libraries\ForbiddenPublicDataClass.kt:60:48: Recommended to use Entity.atName(klass) instead. [UseNamedLocation]
detekt-rules-naming\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\naming\EnumNaming.kt:37:28: Recommended to use Entity.atName(enumEntry) instead. [UseNamedLocation]
detekt-rules-complexity\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\complexity\TooManyFunctions.kt:144:28: Recommended to use Entity.atName(declaration) instead. [UseNamedLocation]
detekt-rules-style\src\main\kotlin\io\gitlab\arturbosch\detekt\rules\style\UseDataClass.kt:106:32: Recommended to use Entity.atName(klass) instead. [UseNamedLocation]
    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    76af16f View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary test complexity (no type resolution)

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    fa6b553 View commit details
    Browse the repository at this point in the history

  8. Remove dead code and support more expressions

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    8278a53 View commit details
    Browse the repository at this point in the history

  9. Rename to UseEntityAtName

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    fa94de4 View commit details
    Browse the repository at this point in the history

  10. Fix nullability issues

    @TWiStErRob
    TWiStErRob committed Oct 19, 2022
    Copy the full SHA
    76d187b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Merge remote-tracking branch 'up/main' into nameIdentifier

    @TWiStErRob
    TWiStErRob committed Oct 24, 2022
    Copy the full SHA
    c4df600 View commit details
    Browse the repository at this point in the history