Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency io.github.detekt.sarif4k:sarif4k to v0.2.0 #5496

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 2, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.github.detekt.sarif4k:sarif4k (source) 0.0.1 -> 0.3.0 age adoption passing confidence

Release Notes

detekt/sarif4k

v0.3.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Nov 2, 2022
Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The renovate bot can detect recently publishes at the delay of a few hours

@chao2zhang chao2zhang added this to the 1.23.0 milestone Nov 2, 2022
@chao2zhang
Copy link
Member

Let's wait for 1.23.

@TWiStErRob
Copy link
Member

The renovate bot can detect recently publishes at the delay of a few hours

Sometimes it's even faster... I got PRs for version bumps where the release process was still in progress, i.e. not all artifacts were published for a monorepo.

@renovate renovate bot changed the title Update dependency io.github.detekt.sarif4k:sarif4k to v0.2.0 Update dependency io.github.detekt.sarif4k:sarif4k to v0.3.0 Nov 22, 2022
@renovate renovate bot force-pushed the renovate/io.github.detekt.sarif4k branch from 3f7a38c to b11f5d7 Compare November 22, 2022 09:58
@TWiStErRob
Copy link
Member

Had a quick look at the failure:

> Task :detekt-report-sarif:compileKotlin FAILED
e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class io.github.detekt.sarif4k.Level.Companion, unresolved supertypes: kotlinx.serialization.KSerializer
    class io.github.detekt.sarif4k.Version.Companion, unresolved supertypes: kotlinx.serialization.KSerializer
Adding -Xextended-compiler-checks argument might provide additional information.

compileClasspath changes from 0.0.1 to 0.2.0
image

compileClasspath changes from 0.2.0 to 0.3.0
image

So we can see the multiplatform change (sarif4k-jvm), but somehow the kotlinx-serialization-json dependency disappeared.

@chao2zhang should sarif4k expose that as compile in POM, or consumers have to add it themselves?

@3flex
Copy link
Member

3flex commented Dec 18, 2022

@chao2zhang will there be an upstream fix or does the build config for detekt need to change?

Just wondering whether we close this and wait for the next version, or update to this version with the build changes needed.

@renovate
Copy link
Contributor Author

renovate bot commented Dec 19, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #5496 (31c9211) into main (6985de3) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5496      +/-   ##
============================================
+ Coverage     85.86%   85.93%   +0.07%     
- Complexity     3628     3658      +30     
============================================
  Files           515      517       +2     
  Lines         12134    12218      +84     
  Branches       2169     2181      +12     
============================================
+ Hits          10419    10500      +81     
- Misses          627      628       +1     
- Partials       1088     1090       +2     
Impacted Files Coverage Δ
...lab/arturbosch/detekt/formatting/FormattingRule.kt 92.06% <0.00%> (-0.13%) ⬇️
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <0.00%> (ø)
...rturbosch/detekt/rules/naming/FunctionMaxLength.kt 100.00% <0.00%> (ø)
...rturbosch/detekt/rules/naming/FunctionMinLength.kt 100.00% <0.00%> (ø)
...rturbosch/detekt/rules/naming/VariableMaxLength.kt 100.00% <0.00%> (ø)
...bosch/detekt/formatting/wrappers/ImportOrdering.kt 100.00% <0.00%> (ø)
...arturbosch/detekt/rules/bugs/CastToNullableType.kt 87.50% <0.00%> (ø)
...ch/detekt/formatting/wrappers/FunctionSignature.kt 100.00% <0.00%> (ø)
...detekt/formatting/wrappers/ArgumentListWrapping.kt 100.00% <0.00%> (ø)
...s/documentation/KDocReferencesNonPublicProperty.kt 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chao2zhang
Copy link
Member

@chao2zhang will there be an upstream fix or does the build config for detekt need to change?

Just wondering whether we close this and wait for the next version, or update to this version with the build changes needed.

Thanks for the nudge. I have not had a time to look into this yet, so will update the version to last known good.

@chao2zhang chao2zhang merged commit ab8edea into main Dec 19, 2022
@chao2zhang chao2zhang deleted the renovate/io.github.detekt.sarif4k branch December 19, 2022 01:12
@3flex 3flex changed the title Update dependency io.github.detekt.sarif4k:sarif4k to v0.3.0 Update dependency io.github.detekt.sarif4k:sarif4k to v0.2.0 Dec 19, 2022
@3flex 3flex removed the blocked label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants